SQL recall

LordOrange · 11-09-2007, 08:35 PM

I've been having some trouble with my loggin script (bellow). It never finds the password out of the databasse so it eather always takes the if in the if.. else or the else indiferent to what the input password is. Could anyone help me...?

<?php
$username="LordOrange";
$con = mysql_connect("mysql3.freehostia.com","benmivl61_m y data","LordRocks");
if (!$con)
{
die('Could not connect: ' . mysql_error());
}
mysql_select_db("benmil61_mydata", $con);
$result = mysql_query("SELECT * FROM reviews WHERE usernames='LordOrange'");
while($row = @mysql_fetch_array($result))
{
echo $row["password"];
}
$password = $row["password"];
echo $password . "<br>";
echo $_POST["password"] . "<br>";
if ($password == $_POST["password"])
echo "<a href='movies-edit.php'>Continue</a>";
else
echo "Incorrect username or password";
?>

UnKnown · 11-10-2007, 12:27 AM

The while loop is

try this

Quote:

<?php
$username="LordOrange";
$con = mysql_connect("mysql3.freehostia.com","benmil61_my data","LordOrangeRocks");
if (!$con)
{
die('Could not connect: ' . mysql_error());
}
mysql_select_db("benmil61_mydata", $con);
$result = mysql_query("SELECT * FROM reviews WHERE usernames='LordOrange'");
while($row = @mysql_fetch_array($result))
{
echo $row["password"];
}
$password = $row["password"];
echo "$password ".$_POST['password']." ";
if ($password == $_POST["password"])
echo "<a href='movies-edit.php'>Continue</a>";
else
echo "Incorrect username or password";

?>

LordOrange · 11-10-2007, 06:48 AM

It still goes with the else statement the whole time and isn't writing anything for the password from the database.

UnKnown · 11-10-2007, 04:09 PM

lets see the database

whats the point of the while loop?

It loops to the last password

LordOrange · 11-10-2007, 05:59 PM

The loop was just the only way I could get it to work

Intripita-MH · 11-11-2007, 04:18 AM

The loop is correct.

I would recommend not doubling up on variable names even though they are in different scopes (post and local) - in other words, $_POST['password'] and $password is a bad idea, especially with register_globals on.

It looks like that setting IS on and thus $password ALWAYS == $password. Rename your variables.

LordOrange · 11-11-2007, 04:30 AM

Thanks, I'll try that

LordOrange · 11-11-2007, 04:44 AM

It still alwys goes with the else code. It also doesn't echo $password.

LordOrange · 11-11-2007, 04:46 AM

This is my code now

Code:

$result = mysql_query("SELECT * FROM users WHERE username='$user'");
while ($row = @mysql_fetch_array($result))
{
echo $row["password"];
}
$password = $row["password"];
echo $password . "<br>";
$pass = $_POST['pass'];
echo $pass."<br>";
if ($password == $pass)
echo "<a href='movies-edit.php'>Continue</a>";
else
echo "Incorrect username or password";

LordOrange · 11-11-2007, 06:30 PM

I found my problem.... My $row variable wasn't global so I could only use it in the scope of the while loop

11-09-2007, 08:35 PM	#1
LordOrange Newcomer Join Date: Nov 2007 Posts: 13	SQL recall I've been having some trouble with my loggin script (bellow). It never finds the password out of the databasse so it eather always takes the if in the if.. else or the else indiferent to what the input password is. Could anyone help me...? <?php $username="LordOrange"; $con = mysql_connect("mysql3.freehostia.com","benmivl61_m y data","LordRocks"); if (!$con) { die('Could not connect: ' . mysql_error()); } mysql_select_db("benmil61_mydata", $con); $result = mysql_query("SELECT * FROM reviews WHERE usernames='LordOrange'"); while($row = @mysql_fetch_array($result)) { echo $row["password"]; } $password = $row["password"]; echo $password . "<br>"; echo $_POST["password"] . "<br>"; if ($password == $_POST["password"]) echo "<a href='movies-edit.php'>Continue</a>"; else echo "Incorrect username or password"; ?> Last edited 11-10-2007 at 06:47 AM.

11-10-2007, 06:48 AM	#3
LordOrange Newcomer Join Date: Nov 2007 Posts: 13	Re: SQL recall It still goes with the else statement the whole time and isn't writing anything for the password from the database.

11-10-2007, 04:09 PM	#4
UnKnown Moderator Join Date: Aug 2006 Posts: 1,134	Re: SQL recall lets see the database whats the point of the while loop? It loops to the last password __________________ Webmaster Resources & Forums / Webmaster Tools & Forum / eCommerce Shopping Basket / Scene Releases

11-10-2007, 05:59 PM	#5
LordOrange Newcomer Join Date: Nov 2007 Posts: 13	Re: SQL recall The loop was just the only way I could get it to work

11-11-2007, 04:18 AM	#6
Intripita-MH Senior Member Join Date: Sep 2006 Posts: 280	Re: SQL recall The loop is correct. I would recommend not doubling up on variable names even though they are in different scopes (post and local) - in other words, $_POST['password'] and $password is a bad idea, especially with register_globals on. It looks like that setting IS on and thus $password ALWAYS == $password. Rename your variables. __________________ Intripita :: web hosting \| development \| conferencing Business-Grade Web Hosting, Professional Conferencing, Effective Web Development by Intripita

11-11-2007, 04:30 AM	#7
LordOrange Newcomer Join Date: Nov 2007 Posts: 13	Re: SQL recall Thanks, I'll try that

11-11-2007, 04:44 AM	#8
LordOrange Newcomer Join Date: Nov 2007 Posts: 13	Re: SQL recall It still alwys goes with the else code. It also doesn't echo $password.

11-11-2007, 06:30 PM	#10
LordOrange Newcomer Join Date: Nov 2007 Posts: 13	Re: SQL recall I found my problem.... My $row variable wasn't global so I could only use it in the scope of the while loop

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Time to recall your old friends.	Webdomain.com	Web Hosting	0	07-10-2007 10:46 PM
What? No SQL Section?	selectsplat	Programming	3	06-14-2007 02:08 AM
Looking for PHP+SQL programmer	Rickzkm	PHP	6	04-29-2007 05:23 AM
Pet Deaths Prompt Recall of Pet Food	lexmarks567	General Talk	4	03-19-2007 11:07 AM
Sql ?	pankaj	MySQL	5	03-15-2007 08:14 PM